minor: Remove unnecessary logic #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Mar 5, 2024
viirya
reviewed
Mar 5, 2024
| // During finding partial aggregation, we must ensure all traversed op are | ||
| // native operators. If not, we should fallback to Spark. | ||
| var seenNonNativeOp = false | ||
| var partialAggInput: Option[Seq[Attribute]] = None |
There was a problem hiding this comment.
Oh, right, this is not needed anymore.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
============================================
- Coverage 33.27% 33.25% -0.03%
Complexity 763 763
============================================
Files 105 105
Lines 35371 35353 -18
Branches 7663 7657 -6
============================================
- Hits 11770 11756 -14
Misses 21151 21151
+ Partials 2450 2446 -4 ☔ View full report in Codecov by Sentry. |
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This removes some unnecessary logic in
QueryPlanSerdewhen handlingFinalaggregation mode.What changes are included in this PR?
After #155, some previous logic on handling
Finalaggregation mode is no longer needed.How are these changes tested?
Existing tests.