build: Enforce scalafix check in CI #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
force-pushed
the
enforce_scalafix
branch
from
3732eef to
9b1472b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
============================================
- Coverage 33.30% 33.30% -0.01%
Complexity 767 767
============================================
Files 107 107
Lines 35372 35375 +3
Branches 7657 7658 +1
============================================
Hits 11782 11782
- Misses 21144 21145 +1
- Partials 2446 2448 +2 ☔ View full report in Codecov by Sentry. |
sunchao
approved these changes
Mar 13, 2024
| @@ -38,6 +38,7 @@ clean: | |||
| bench: | |||
| cd core && RUSTFLAGS="-Ctarget-cpu=native" cargo bench $(filter-out $@,$(MAKECMDGOALS)) | |||
| format: | |||
| cd core && cargo fmt | |||
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When developing #179 and
CometRowToColumnarsupport, I noticed suspicious errors. It turns out that scalafix in the java-test action rewrites the scala source code and have conflict result withscalafmt(used by spotless). It's hard to debug such cases and quite annoying.What changes are included in this PR?
scalafix:scalafixto the current codebaseformattarget in Makefile so that developers can format code by simply type:make formatHow are these changes tested?
Existing test and CI checks