fix: zero Arrow Array offset before sending across FFI #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ero offset before FFI to work around possible Arrow Java issue.
mbutrovich
commented
Jul 31, 2025
mbutrovich
commented
Jul 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
============================================
+ Coverage 56.12% 58.76% +2.63%
- Complexity 976 1253 +277
============================================
Files 119 137 +18
Lines 11743 13160 +1417
Branches 2251 2388 +137
============================================
+ Hits 6591 7733 +1142
- Misses 4012 4196 +184
- Partials 1140 1231 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Kontinuation FYI |
andygrove
reviewed
Jul 31, 2025
comphead
reviewed
Jul 31, 2025
andygrove
approved these changes
Jul 31, 2025
comphead
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
lgtm thanks @mbutrovich
Lets merge it and I take the fix to df 49 upgrade branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See #2051. Not sure this completely closes the issue, since I consider this a workaround.
Rationale for this change
What changes are included in this PR?
How are these changes tested?
I was unable to write a deterministic test that manifests the issue, but the modified first/last test mentioned in this comment is fixed by this PR.