test: Add TPC-H test results #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=========================================
Coverage 33.32% 33.32%
Complexity 768 768
=========================================
Files 107 107
Lines 37037 37037
Branches 8106 8106
=========================================
Hits 12341 12341
Misses 22099 22099
Partials 2597 2597 ☔ View full report in Codecov by Sentry. |
sunchao
reviewed
Mar 21, 2024
|
Ah, yeah, they are disabled because the outputs are different to Spark. But for these output files, we should generate them. Let me add them. |
sunchao
approved these changes
Mar 21, 2024
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
We have already added back TPC-DS query results in #77. This adds back TPC-H query results.
What changes are included in this PR?
Adds back TPC-H query results golden files to the repo. These files were generated using CometTPCHQuerySuite with Comet turned off, to make sure it is the same as Spark's results.
How are these changes tested?