feat: Change default off-heap memory pool from greedy_unified to fair_unified#2526
Merged
mbutrovich merged 3 commits intoapache:mainfrom Oct 6, 2025
Merged
Conversation
andygrove
changed the title
greedy_unified to fair_unifiedgreedy_unified to fair_unified
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
============================================
+ Coverage 56.12% 59.00% +2.88%
- Complexity 976 1457 +481
============================================
Files 119 146 +27
Lines 11743 13566 +1823
Branches 2251 2358 +107
============================================
+ Hits 6591 8005 +1414
- Misses 4012 4340 +328
- Partials 1140 1221 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
greedy_unified to fair_unifiedgreedy_unified to fair_unified
mbutrovich
approved these changes
Oct 6, 2025
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @andygrove! Good find!
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Oct 6, 2025
andygrove
added a commit
that referenced
this pull request
Oct 6, 2025
Contributor
|
Good one Andy! |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2452
Rationale for this change
The greedy unified pool does not work well when DataFusion's SortMergeJoin needs to spill.
What changes are included in this PR?
How are these changes tested?