Skip to content

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

Closes #2586.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.16%. Comparing base (f09f8af) to head (a559b12).
⚠️ Report is 638 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2605      +/-   ##
============================================
+ Coverage     56.12%   59.16%   +3.03%     
- Complexity      976     1447     +471     
============================================
  Files           119      147      +28     
  Lines         11743    13743    +2000     
  Branches       2251     2360     +109     
============================================
+ Hits           6591     8131    +1540     
- Misses         4012     4388     +376     
- Partials       1140     1224      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

assertables = "9"
hex = "0.4.3"
datafusion-functions-nested = { version = "50.2.0" }
datafusion-functions-nested = { version="50.3.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended loss of spaces?

arrow = { version = "56.0.0", features = ["prettyprint", "ffi", "chrono-tz"] }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "=56.2.0", default-features = false, features = ["experimental"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you fixed the missing spaces here!

Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI, no sense in running CI again for a pair of missing spaces.

@mbutrovich mbutrovich merged commit fa963bf into apache:main Oct 24, 2025
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: support DataFusion 50.3.0

3 participants