-
Notifications
You must be signed in to change notification settings - Fork 253
feat: support cot #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cot #2755
Conversation
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @psvri for your contribution please add the function to the fuzz testing
https://github.com/apache/datafusion-comet/blob/main/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala#L94
Added the function for fuzz testing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
============================================
+ Coverage 56.12% 58.63% +2.50%
- Complexity 976 1477 +501
============================================
Files 119 163 +44
Lines 11743 13991 +2248
Branches 2251 2378 +127
============================================
+ Hits 6591 8203 +1612
- Misses 4012 4580 +568
- Partials 1140 1208 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @psvri great PR
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @psvri
Which issue does this PR close?
Partially implements #240
Rationale for this change
Add support for cot spark expression
What changes are included in this PR?
How are these changes tested?
UT tests and manual testing