Skip to content

Conversation

@psvri
Copy link
Contributor

@psvri psvri commented Nov 10, 2025

Which issue does this PR close?

Partially implements #240

Rationale for this change

Add support for cot spark expression

What changes are included in this PR?

How are these changes tested?

UT tests and manual testing

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psvri
Copy link
Contributor Author

psvri commented Nov 11, 2025

Thanks @psvri for your contribution please add the function to the fuzz testing https://github.com/apache/datafusion-comet/blob/main/fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala#L94

Added the function for fuzz testing

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.63%. Comparing base (f09f8af) to head (04806d5).
⚠️ Report is 686 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2755      +/-   ##
============================================
+ Coverage     56.12%   58.63%   +2.50%     
- Complexity      976     1477     +501     
============================================
  Files           119      163      +44     
  Lines         11743    13991    +2248     
  Branches       2251     2378     +127     
============================================
+ Hits           6591     8203    +1612     
- Misses         4012     4580     +568     
- Partials       1140     1208      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psvri great PR

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psvri

@andygrove andygrove merged commit 5f204c9 into apache:main Nov 13, 2025
102 checks passed
@psvri psvri deleted the feat_cot branch November 14, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants