fix: Implement producedAttributes for CometWindowExec#2789
Merged
comphead merged 5 commits intoapache:mainfrom Nov 17, 2025
Merged
fix: Implement producedAttributes for CometWindowExec#2789comphead merged 5 commits intoapache:mainfrom
comphead merged 5 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
============================================
+ Coverage 56.12% 58.30% +2.17%
- Complexity 976 1422 +446
============================================
Files 119 157 +38
Lines 11743 14115 +2372
Branches 2251 2365 +114
============================================
+ Hits 6591 8230 +1639
- Misses 4012 4694 +682
- Partials 1140 1191 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wForget
approved these changes
Nov 17, 2025
Member
wForget
left a comment
There was a problem hiding this comment.
@rahulbabarwal89 Thanks for your work. CometWindowExec was disabled in #2726, but this change looks good to me.
Member
comphead
approved these changes
Nov 17, 2025
Contributor
comphead
left a comment
There was a problem hiding this comment.
Thanks @rahulbabarwal89 thats a nice contribution to fix windows.
And thanks @wForget for the review
Contributor
|
As a followup I'm planning to amend |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
* Fix 2710 CometWindowExec should correctly account output attributes Co-authored-by: Rahul Babarwal <rahul.babarwal@sumologic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Which issue does this PR close?
Current plan for windows is
+- !CometWindowExec [a#19, b#20, c#21, sum_c#25L], [sum(c#21) windowspecdefinition(a#19, specifiedwindowframe(RowFrame, unboundedpreceding$(), unboundedfollowing$())) AS sum_c#25L], [a#19]
+- CometSort [a#19, b#20, c#21], [a#19 ASC NULLS FIRST]
+- CometExchange hashpartitioning(a#19, 10), ENSURE_REQUIREMENTS, CometNativeShuffle, [plan_id=87]
+- CometScan [native_iceberg_compat] parquet [a#19,b#20,c#21] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/private/var/folders/6f/_s1vnnd55zgfkx7zlwnrnv0h0000gn/T/spark-89..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<a:int,b:int,c:int>
The exclamation mark usually means discrepancy for outputAttributes
Closes #2710.
Rationale for this change
What changes are included in this PR?
How are these changes tested?