chore: Invert usingDataSourceExec test helper to usingLegacyNativeCometScan#3310
Merged
mbutrovich merged 2 commits intoapache:mainfrom Jan 30, 2026
Merged
Conversation
…pache#3309) With native_datafusion enabled in auto scan mode, test helpers that check for specific scan config values fail because auto resolves at plan time, not config time. Invert the logic so tests check for the legacy native_comet mode instead, which is forward-compatible with auto and any future scan implementations. - Rename usingDataSourceExec → usingLegacyNativeCometScan (inverted) - Rename usingDataSourceExecWithIncompatTypes → hasUnsignedSmallIntSafetyCheck - Update all call sites across 11 test files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
force-pushed
the
invert-usingDataSourceExec
branch
from
081bace to
c9a5052
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
============================================
+ Coverage 56.12% 59.90% +3.77%
- Complexity 976 1473 +497
============================================
Files 119 175 +56
Lines 11743 16167 +4424
Branches 2251 2682 +431
============================================
+ Hits 6591 9685 +3094
- Misses 4012 5132 +1120
- Partials 1140 1350 +210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The inversion from usingDataSourceExec to !usingLegacyNativeCometScan incorrectly broadened the condition to include native_iceberg_compat and auto modes, which do not support schema evolution (INT32 to bigint). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
changed the title
mbutrovich
approved these changes
Jan 30, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks @andygrove, that makes it more clear what's going on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3309
Since
native_cometis deprecated and the default path is now DataSource-based, this PR inverts the logic:usingDataSourceExec→usingLegacyNativeCometScan(returnstrueonly when config is explicitlynative_comet)usingDataSourceExecWithIncompatTypes→hasUnsignedSmallIntSafetyCheckSCAN_NATIVE_DATAFUSIONcheck in the schema evolution test with!usingLegacyNativeCometScanThis is forward-compatible with
autoand any future scan implementations.Test plan
🤖 Generated with Claude Code