fix: Fix space() with negative input#3347
Merged
andygrove merged 3 commits intoapache:mainfrom Jan 30, 2026
Merged
Conversation
The string_space function previously failed with overflow when given negative input values. Now treats negative lengths as zero, returning empty strings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hsiang-c
commented
Jan 30, 2026
|
|
||
| test("string_space") { | ||
| withParquetTable((0 until 5).map(i => (i, i + 1)), "tbl") { | ||
| withParquetTable((0 until 5).map(i => (-i, i + 1)), "tbl") { |
Contributor
Author
There was a problem hiding this comment.
Will change string_space.sql once #3328 is merged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
============================================
+ Coverage 56.12% 59.95% +3.82%
- Complexity 976 1473 +497
============================================
Files 119 175 +56
Lines 11743 16167 +4424
Branches 2251 2682 +431
============================================
+ Hits 6591 9693 +3102
- Misses 4012 5126 +1114
- Partials 1140 1348 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
approved these changes
Jan 30, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @hsiang-c! I did a quick experiment to see if I could come up with a bitwise arithmetic solution that resulted in fewer instructions than max(0) generates, but unsurprisingly the compiler is smart enough for that.
andygrove
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3326
Rationale for this change
space()on negative values throwsfailed to round upto multiple of 64exceptionWhat changes are included in this PR?
How are these changes tested?