fix: unignore row index Spark SQL tests for native_datafusion#3414
Merged
mbutrovich merged 1 commit intoapache:mainfrom Feb 5, 2026
Merged
fix: unignore row index Spark SQL tests for native_datafusion#3414mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich merged 1 commit intoapache:mainfrom
Conversation
The native_datafusion scan already falls back to Spark when row index metadata columns are requested, so these tests should pass. Closes apache#3317 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andygrove
force-pushed
the
fix-3317-row-index-fallback
branch
from
ba0ebf2 to
a599335
Compare
andygrove
changed the title
mbutrovich
approved these changes
Feb 5, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Makes sense to me! Thanks @andygrove. Do we have a followup issue to implement this? I believe there are related upstream arrow-rs efforts.
Member
Author
Good point. I just filed #3432 |
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Feb 6, 2026
Row index tests (apache#3317) and field ID tests (apache#3316) are both fixed upstream in apache#3414 and apache#3415, so no additional test ignores are needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IgnoreCometNativeDataFusiontest annotations for [native_datafusion] [Spark SQL Tests] _tmp_metadata_row_index not populated #3317 from the Spark 3.5.8 diffnative_datafusionscan already falls back to Spark when row index metadata columns (_tmp_metadata_row_index) are requested, so these tests should passCloses #3317
Test plan
ParquetFileMetadataStructRowIndexSuitepass withnative_datafusionenabled in CI🤖 Generated with Claude Code