Skip to content

fix: support literal sha2() with 'Unsupported argument types' #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0lai0 wants to merge 6 commits into
base: main
Choose a base branch
from
+11 −3
Open

fix: support literal sha2() with 'Unsupported argument types' #3466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ffc300
Fix Native Engine Crash on Literal sha2()
0lai0 Feb 10, 2026
c411f7c
Merge branch 'apache:main' into native_engine_crashes_on_sha2
0lai0 Feb 11, 2026
2a57e6d
Merge branch 'apache:main' into native_engine_crashes_on_sha2
0lai0 Feb 12, 2026
9756c9e
fix lint
0lai0 Feb 12, 2026
d978099
Merge branch 'main' into native_engine_crashes_on_sha2
0lai0 Feb 17, 2026
9af4b57
remove sha2() rust
0lai0 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions native/core/src/execution/jni_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ use datafusion_spark::function::datetime::date_sub::SparkDateSub;
use datafusion_spark::function::datetime::last_day::SparkLastDay;
use datafusion_spark::function::datetime::next_day::SparkNextDay;
use datafusion_spark::function::hash::sha1::SparkSha1;
use datafusion_spark::function::hash::sha2::SparkSha2;
use datafusion_spark::function::map::map_from_entries::MapFromEntries;
use datafusion_spark::function::math::expm1::SparkExpm1;
use datafusion_spark::function::math::hex::SparkHex;
Expand Down Expand Up @@ -362,7 +361,6 @@ fn prepare_datafusion_session_context(
// register UDFs from datafusion-spark crate
fn register_datafusion_spark_function(session_ctx: &SessionContext) {
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkExpm1::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkSha2::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(CharFunc::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkBitGet::default()));
session_ctx.register_udf(ScalarUDF::new_from_impl(SparkDateAdd::default()));
Expand Down
10 changes: 10 additions & 0 deletions spark/src/main/scala/org/apache/comet/serde/hash.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@ object CometMurmur3Hash extends CometExpressionSerde[Murmur3Hash] {
}

object CometSha2 extends CometExpressionSerde[Sha2] {
override def getSupportLevel(expr: Sha2): SupportLevel = {
// If all children are foldable (constant/scalar), let Spark evaluate sha2
// to avoid relying on DataFusion support for purely scalar invocations.
if (expr.children.forall(_.foldable)) {
Unsupported(Some("sha2 with all scalar arguments is evaluated in Spark"))
} else {
Compatible()
}
}

override def convert(
expr: Sha2,
inputs: Seq[Attribute],
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/resources/sql-tests/expressions/hash/hash.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ query
SELECT md5(col), md5(cast(a as string)), md5(cast(b as string)), hash(col), hash(col, 1), hash(col, 0), hash(col, a, b), hash(b, a, col), xxhash64(col), xxhash64(col, 1), xxhash64(col, 0), xxhash64(col, a, b), xxhash64(b, a, col), sha2(col, 0), sha2(col, 256), sha2(col, 224), sha2(col, 384), sha2(col, 512), sha2(col, 128), sha2(col, -1), sha1(col), sha1(cast(a as string)), sha1(cast(b as string)) FROM test

-- literal arguments
query ignore(https://github.com/apache/datafusion-comet/issues/3340)
query
SELECT md5('Spark SQL'), sha1('test'), sha2('test', 256), hash('test'), xxhash64('test')
Loading