bug: Fix supported types for Bool type casts#3506
Closed
coderfender wants to merge 2 commits intoapache:mainfrom
Closed
bug: Fix supported types for Bool type casts#3506coderfender wants to merge 2 commits intoapache:mainfrom
coderfender wants to merge 2 commits intoapache:mainfrom
Conversation
coderfender
changed the title
Contributor
Author
|
@andygrove please take a look whenever you get a chance |
Member
Could you add a test that demonstrates the bug that the code change is intended to fix? |
Contributor
Author
|
Sure let me go ahead and add a test. Thank you for the quick review |
andygrove
reviewed
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Breaking down bug fixes from : #3491 into a separate PR
Essentially we have the matches macro which supports bool to string cast but the
can_cast_to_boolean' doesnt. Given that the latter is only called on nested type casts, this was an edge case whose occurrence was not prevalent and the bug prevailed. This test is to fix that bug and ensure consistency all overCloses #3509 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?