Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect input schema when preparing result expressions for HashAggregation #501

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 1, 2024

Which issue does this PR close?

Closes #502.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya changed the title chore: Incorrect input schema when preparing result expressions for Has… chore: Incorrect input schema when preparing result expressions for HashAggregation Jun 1, 2024
@viirya viirya changed the title chore: Incorrect input schema when preparing result expressions for HashAggregation fix: Incorrect input schema when preparing result expressions for HashAggregation Jun 1, 2024
@viirya
Copy link
Member Author

viirya commented Jun 1, 2024

cc @huaxingao

@viirya
Copy link
Member Author

viirya commented Jun 1, 2024

cc @sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit 24781fb into apache:main Jun 1, 2024
46 of 47 checks passed
@viirya
Copy link
Member Author

viirya commented Jun 1, 2024

Merged. Thanks @sunchao

@viirya viirya deleted the fix_agg_schema branch June 1, 2024 21:05
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect input schema when preparing result expressions for HashAggregation
2 participants