feat: Nested map support for columnar shuffle #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
approved these changes
Feb 20, 2024
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #52.
Rationale for this change
Contributed internal patch of map shuffle support to Comet.
What changes are included in this PR?
This patch implements native map accessor for Spark
UnsafeRows. So columnar shuffle can support nested map field.Note that deeply nested map is not supported. Due to the design of
MapBuilder, it has aK: ArrayBuilderandV: ArrayBuilderas type parameter. It makes hard to construct an arbitrarily nestedMapBuilder. Actually map of map sounds like a DataType rarely to be used in practice. Maybe we don't need to support it.How are these changes tested?