-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Proposal for source release process #556
Conversation
dev/release/README.md
Outdated
@@ -17,7 +17,7 @@ specific language governing permissions and limitations | |||
under the License. | |||
--> | |||
|
|||
# Comet Release Process | |||
# Comet Source Release Process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Source means here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are defining the process for making an official ASF release, which must be a source tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev/release/README.md
Outdated
- Push a release candidate tag (e.g. 0.1.0-rc1) to the Apache repository | ||
Here are the steps, using the 0.1.0 release as an example: | ||
|
||
- Create a release branch from the latest commit in main (e.g. `git checkout -b release-0.1.0`) and push to the Apache repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just thinking - perhaps we can convert all steps into github commands?
Thanks for the review @comphead. I added the git commands for most steps. |
Create a release branch from the latest commit in main and push to the Apache repo: | ||
|
||
```shell | ||
get fetch apache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apache
is a different repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the name I use for my remote, but it would be good to clarify this in the docs.
$ git remote -v | grep apache
apache git@github.com:apache/datafusion-comet.git (fetch)
apache git@github.com:apache/datafusion-comet.git (push)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I thought it might be a nickname for a particular repo. It'd be good to make it clear in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @andygrove
👍
existing Spark jobs and report any functional issues or performance regressions. | ||
|
||
Another way of verifying the release is to follow the | ||
[Comet Benchmarking Guide](https://datafusion.apache.org/comet/contributor-guide/benchmarking.html) and compare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it just comes to my mind if its possible to generate benches automatically per release. So Comet have a trend
* Source release process proposal * small refinement * add more detail * fix * more detail * title * prettier * ASF header * address feedback
Which issue does this PR close?
Part of #394
Rationale for this change
We want to create our first source release soon, so we need to define the process.
What changes are included in this PR?
Add proposed source release process to release documentation (rendered version).
How are these changes tested?
Not tested