Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback to Spark for window expression with range frame #719

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: Fallback to Spark for window expression with range frame #719

merged 2 commits into from
Jul 25, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 24, 2024 •
edited
Loading

Which issue does this PR close?

Closes #720.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya changed the title fix: Disable unsupported window frame type fix: Fallback to Spark for window expression with range frame Jul 24, 2024
huaxingao
huaxingao approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this problem @viirya

@viirya viirya merged commit f682d5b into apache:main Jul 25, 2024
74 checks passed
@viirya
Copy link
Member Author

viirya commented Jul 25, 2024

Thanks @huaxingao

@viirya viirya deleted the fix_windowframe branch July 25, 2024 04:08
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
@viirya @huaxingao
fix: Fallback to Spark for window expression with range frame (apache…
a70013b 
…#719)

* fix: Disable unsupported window frame type

* Fix test

(cherry picked from commit f682d5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaxingao huaxingao huaxingao approved these changes

@kazuyukitanimura kazuyukitanimura Awaiting requested review from kazuyukitanimura

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comet query with range frame will fail
2 participants
@viirya @huaxingao