-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove castting on decimals with a small precision to decimal256 #741
fix: Remove castting on decimals with a small precision to decimal256 #741
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
=============================================
+ Coverage 33.57% 53.75% +20.17%
+ Complexity 830 813 -17
=============================================
Files 110 107 -3
Lines 42608 10273 -32335
Branches 9352 1934 -7418
=============================================
- Hits 14306 5522 -8784
+ Misses 25347 3774 -21573
+ Partials 2955 977 -1978 ☔ View full report in Codecov by Sentry. |
I created a criterion benchmark for decimal_div in #743. The results look great for the changes in this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on the decimal math in here, but all tests are passing, and performance is improved, so LGTM
Thank you @andygrove merged |
…apache#741) ## Which issue does this PR close? Part of apache#670 ## Rationale for this change This PR improves the native execution performance on decimals with a small precision ## What changes are included in this PR? This PR changes not to promote decimal128 to decimal256 if the precisions are small enough ## How are these changes tested? Existing tests (cherry picked from commit 25957dd)
Which issue does this PR close?
Part of #670
Rationale for this change
This PR improves the native execution performance on decimals with a small precision
What changes are included in this PR?
This PR changes not to promote decimal128 to decimal256 if the precisions are small enough
How are these changes tested?
Existing tests