Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to Spark for unsupported input besides ordering #768

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 2, 2024

Which issue does this PR close?

Closes #769.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.66%. Comparing base (e33d560) to head (cef4884).
Report is 4 commits behind head on main.

Files Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 33.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #768      +/-   ##
============================================
+ Coverage     33.63%   33.66%   +0.02%     
- Complexity      822      836      +14     
============================================
  Files           111      111              
  Lines         42650    42722      +72     
  Branches       9390     9397       +7     
============================================
+ Hits          14345    14381      +36     
- Misses        25335    25369      +34     
- Partials       2970     2972       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viirya viirya requested a review from andygrove August 2, 2024 20:53
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya
Copy link
Member Author

viirya commented Aug 2, 2024

Thank you @huaxingao

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

@viirya viirya merged commit ab2dcaa into apache:main Aug 2, 2024
74 checks passed
@viirya
Copy link
Member Author

viirya commented Aug 2, 2024

Thanks @huaxingao @kazuyukitanimura

@viirya viirya deleted the fix_ordering branch August 2, 2024 21:41
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback to Spark for unsupported input besides ordering
4 participants