feat: Add config option to enable converting CSV to columnar #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parthchandra could you review? |
viirya
approved these changes
Aug 27, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
) * CSV * save progress * test passes * Revert additional json test * fix path * revert a change * update docs * scalastyle (cherry picked from commit 3d1dbb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Allow Comet to accelerate queries that read from CSV files.
What changes are included in this PR?
Add a config option to enable converting CSV file scans into Arrow format so that Comet can operate on the rest of the query.
How are these changes tested?
Simple test added. The feature is disabled by default and should only be enabled once we have more comprehensive tests.