-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Documenting Helm chart for Comet Kube execution #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
commented
Aug 27, 2024
@andygrove please have a look |
andygrove
reviewed
Aug 30, 2024
andygrove
reviewed
Aug 30, 2024
andygrove
reviewed
Aug 30, 2024
docs/source/user-guide/kubernetes.md
Outdated
spec: | ||
type: Scala | ||
mode: cluster | ||
image: ghcr.io/apache/datafusion-comet:spark-3.4-scala-2.12-0.2.0-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the final 0.2.0 image now instead of 0.2.0-rc1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
andygrove
approved these changes
Sep 3, 2024
viirya
reviewed
Sep 3, 2024
viirya
changed the title
[doc] Documenting Helm chart for Comet Kube execution
doc: Documenting Helm chart for Comet Kube execution
Sep 3, 2024
Co-authored-by: Andy Grove <agrove@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #689 .
Rationale for this change
Document how to deploy Apache Spark with Comet accelerator to the Kubernetes using Helm
What changes are included in this PR?
How are these changes tested?