chore: Enable shuffle by default #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Aug 29, 2024
Comment on lines
+78
to
79
| // TODO we should no longer be disabling COALESCE_PARTITIONS_ENABLED | ||
| conf.set(SQLConf.COALESCE_PARTITIONS_ENABLED.key, "false") |
There was a problem hiding this comment.
Unrelated to this PR, but we should fix this in a separate PR
There was a problem hiding this comment.
I removed it in https://github.com/apache/datafusion-comet/pull/553/files#r1730694991, in order to trigger a test case failed in current code.
andygrove
commented
Aug 29, 2024
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala
Outdated
Show resolved
Hide resolved
andygrove
requested review from
viirya,
kazuyukitanimura,
huaxingao and
comphead
comphead
reviewed
Aug 29, 2024
docs/source/user-guide/configs.md
Outdated
| @@ -50,8 +50,7 @@ Comet provides the following configuration settings. | |||
| | spark.comet.exec.memoryFraction | The fraction of memory from Comet memory overhead that the native memory manager can use for execution. The purpose of this config is to set aside memory for untracked data structures, as well as imprecise size estimation during memory acquisition. Default value is 0.7. | 0.7 | | |||
| | spark.comet.exec.project.enabled | Whether to enable project by default. | true | | |||
| | spark.comet.exec.shuffle.codec | The codec of Comet native shuffle used to compress shuffle data. Only zstd is supported. | zstd | | |||
| | spark.comet.exec.shuffle.enabled | Whether to enable Comet native shuffle. By default, this config is false. Note that this requires setting 'spark.shuffle.manager' to 'org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager'. 'spark.shuffle.manager' must be set before starting the Spark application and cannot be changed during the application. | false | | |||
| | spark.comet.exec.shuffle.mode | The mode of Comet shuffle. This config is only effective if Comet shuffle is enabled. Available modes are 'native', 'jvm', and 'auto'. 'native' is for native shuffle which has best performance in general. 'jvm' is for jvm-based columnar shuffle which has higher coverage than native shuffle. 'auto' is for Comet to choose the best shuffle mode based on the query plan. By default, this config is 'auto'. | auto | | |||
| | spark.comet.exec.shuffle.enabled | Whether to enable Comet native shuffle. By default, this config is false. Note that this requires setting 'spark.shuffle.manager' to 'org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager'. 'spark.shuffle.manager' must be set before starting the Spark application and cannot be changed during the application. | true | | |||
There was a problem hiding this comment.
Suggested change
| | spark.comet.exec.shuffle.enabled | Whether to enable Comet native shuffle. By default, this config is false. Note that this requires setting 'spark.shuffle.manager' to 'org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager'. 'spark.shuffle.manager' must be set before starting the Spark application and cannot be changed during the application. | true | | |
| | spark.comet.exec.shuffle.enabled | Whether to enable Comet native shuffle. By default, this config is true. Note that this requires setting 'spark.shuffle.manager' to 'org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager'. 'spark.shuffle.manager' must be set before starting the Spark application and cannot be changed during the application. | true | |
comphead
reviewed
Aug 29, 2024
| @@ -189,7 +189,7 @@ object CometConf extends ShimCometConf { | |||
| "'spark.shuffle.manager' must be set before starting the Spark application and " + | |||
| "cannot be changed during the application.") | |||
| .booleanConf | |||
| .createWithDefault(false) | |||
| .createWithDefault(true) | |||
There was a problem hiding this comment.
We also need to fix default value in description
There was a problem hiding this comment.
We should probably automate adding the text stating the default value. Thanks for catching that.
comphead
approved these changes
Aug 29, 2024
viirya
approved these changes
Aug 29, 2024
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* enable shuffle by default * disable shuffle in CometTestBase * format * fix regressions * fix * fix more * fix more * fix regression * fix regressions * Revert refactor * format * update docs (cherry picked from commit be10fee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
We would like to enalbe shuffle by default.
What changes are included in this PR?
spark.comet.exec.shuffle.enabledfromfalsetotrueORDER BYclause to some queries to make the tests deterministicHow are these changes tested?