fix: Avoid exception caused by broadcasting empty result #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Feb 22, 2024
| val expected = (0 until numParts).flatMap(_ => (0 until 5).map(i => i + 1)).sorted | ||
|
|
||
| assert(rowContents === expected) | ||
| Seq(true, false).foreach { emptyBroadcast => |
There was a problem hiding this comment.
Hmm, the test looks complicated by the change. Could you add a new test for empty broadcast case instead of modifying current one?
viirya
reviewed
Feb 22, 2024
| @@ -81,7 +81,11 @@ abstract class CometExec extends CometPlan { | |||
|
|
|||
| out.flush() | |||
| out.close() | |||
| Iterator((count, cbbos.toChunkedByteBuffer)) | |||
| if (out.size() > 0) { | |||
There was a problem hiding this comment.
I think this is due to the extra bytes being written in the encode compressed stream, causing it to be determined not empty in CometExec$.decodeBatches.
If there are extra bytes written, is out.size() 0?
There was a problem hiding this comment.
Oh, I see. The compressed stream is wrapped in out. When it is flushed, it might write compression related bytes which are not counted in out.size().
There was a problem hiding this comment.
How about we check count > 0 instead?
viirya
approved these changes
Feb 23, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #91.
Rationale for this change
What changes are included in this PR?
How are these changes tested?