-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: cast timestamp test #468 #923
Conversation
@viirya @andygrove @parthchandra , please take a look. |
Thanks @himadripal for your contribution, triggering the workflow |
Please fix the PR title,
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
=============================================
+ Coverage 34.03% 54.92% +20.88%
+ Complexity 883 853 -30
=============================================
Files 113 109 -4
Lines 43170 10697 -32473
Branches 9516 2050 -7466
=============================================
- Hits 14693 5875 -8818
+ Misses 25471 3789 -21682
+ Partials 3006 1033 -1973 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @himadripal
@andygrove please have a look as well, as you originated this ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik, these tests were being run only for Spar k 3.4 because Spark had incorrect output for these cases in 3.2 and we could not make these tests pass. If these tests pass for Spark 3.3, we can remove this check.
The issue claims that the test fails to pass for Spark 3.2 and 3.3. We don't have 3.2 test but 3.3 is still there. Any change that makes it passed in Spark 3.3 now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @himadripal
When I filed the issue it looks like I only tested with Spark 3.2 and did not test with 3.3, so I am not sure if there was really an issue with 3.3 at that time or not.
Removed assume(isspark34Plus).
Tested with `make test PROFILES="-Pspark-3.3".
3.2 is not supported.
All worked.
Closes #468