Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary google test import in CI once upstream is resolved #763

Closed
timsaucer opened this issue Jul 17, 2024 · 0 comments · Fixed by #773
Closed

Remove unnecessary google test import in CI once upstream is resolved #763

timsaucer opened this issue Jul 17, 2024 · 0 comments · Fixed by #773
Labels
bug Something isn't working

Comments

@timsaucer
Copy link
Contributor

Describe the bug
After MaterializeInc/rust-protobuf-native#20 is resolved, remove the temporary CI lines marked in

  • .github/workflows/build.yml
  • .github/workflows/test.yaml

To Reproduce
If you remove those lines, CI currently fails due to the linked issue above.

Expected behavior
CI should pass without needing to install google test suite.

Additional context
These lines were added as a temporary work around for CI.
@timsaucer timsaucer added the bug Something isn't working label Jul 17, 2024
@timsaucer timsaucer mentioned this issue Jul 17, 2024
Merged
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Jul 25, 2024
@Michael-J-Ward
update deps to force new protobuf-src
dc8578c 
The new version **should** remove the need for the blocked GH action.

Ref: MaterializeInc/rust-protobuf-native#20
Ref: apache#763
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Jul 25, 2024
@Michael-J-Ward
remove googletest-installer github action
8efec4b 
Fixes apache#763
@Michael-J-Ward Michael-J-Ward mentioned this issue Jul 25, 2024
Merged
Michael-J-Ward added a commit to Michael-J-Ward/datafusion-python that referenced this issue Jul 25, 2024
@Michael-J-Ward
remove googletest-installer github action
3c84a89 
Fixes apache#763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade protobuf and remove GH Action googletest-installer Michael-J-Ward/datafusion-python
1 participant
@timsaucer