Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README and add more examples #137

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jan 19, 2023

Which issue does this PR close?

N/A

Rationale for this change

The README started out with PyArrow integration and did not show simple examples of querying files.

What changes are included in this PR?

  • Updated README (see rendered version)
  • Add examples directory containing examples

Are there any user-facing changes?

@andygrove andygrove marked this pull request as ready for review January 19, 2023 01:41
@andygrove andygrove marked this pull request as draft January 19, 2023 02:26
@andygrove andygrove changed the title Add simple examples Improve README and add more examples Jan 19, 2023
@andygrove andygrove marked this pull request as ready for review January 19, 2023 02:54
Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge +1! Examples and documentation are always great.

@jdye64
Copy link
Contributor

jdye64 commented Jan 19, 2023

FYI - I'm working on adding support for compressed file reading and will update the examples to show that as well once completed.

@andygrove andygrove merged commit e05f217 into apache:master Jan 19, 2023
@andygrove andygrove deleted the examples branch January 19, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants