Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrait bindings #145

Merged
merged 21 commits into from
Jan 20, 2023
Merged

Substrait bindings #145

merged 21 commits into from
Jan 20, 2023

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jan 19, 2023

Which issue does this PR close?

Closes #132

Cargo.toml Outdated Show resolved Hide resolved
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 20, 2023

I'm currently troubleshooting why github actions is not triggering

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks @jdye64

@andygrove andygrove merged commit 950a578 into apache:master Jan 20, 2023
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 20, 2023

Hey @andygrove thanks! However, something is broken with the Github actions setup. While this PR showed all the CI passing that was actually a red herring. Only a single RAT action ran. I have another open issue for getting that resolved here I actually think we need to revert this commit or otherwise any further CI jobs will always fail until that maturin-action is added to the Apache whitelist of actions allowed to be used in this repo.

Or we can just expect that to be done today and wait. Up to you but wanted to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python bindings for substrait module
2 participants