Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrame methods for accessing plans #153

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@andygrove andygrove marked this pull request as ready for review January 27, 2023 01:24
Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one question about module name. If that is intended it is fine but the location of the file leads me to believe that is a copy/paste mistake.


use pyo3::prelude::*;

#[pyclass(name = "ExecutionPlan", module = "substrait", subclass)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of the substrait module? Seems like it should be module = datafusion any chance you copy/pasted this? I could be wrong too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@andygrove andygrove merged commit 0e74732 into apache:main Jan 27, 2023
@andygrove andygrove deleted the access-plans branch January 27, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants