Make from_substrait_plan return DataFrame instead of LogicalPlan #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdye64 fyi |
jdye64
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
Fine with the changes but thinking we could add another method, in the PySubstraitSerializer maybe?, to have that functionality to get the LogicalPlan itself. I know Dask-SQL is planning on using this to get just the logical plan for example and they don't use the DataFrame since they use a Dask Dataframe. We can just make another issue and add that later though unless you want to copy/paste it now
andygrove
force-pushed
the
from_substrait_plan_df
branch
from
71d5fb1
to
d6a2362
Compare
|
I changed the approach here and reverted my previous changes. There is now a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
I want to be able to execute a substrait plan and there is no way to do that after deserializing a logical plan from substrait.
What changes are included in this PR?
Change
from_substrait_planto returnDataFrameinstead ofLogicalPlanAre there any user-facing changes?