Implement to_pandas()
#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simicd
force-pushed
the
feature/to-pandas
branch
from
28be584 to
61b5da6
Compare
andygrove
reviewed
Feb 19, 2023
Member
|
This is looking good so far. Thanks @simicd |
|
Can you also update the documentation? -# collect as list of pyarrow.RecordBatch
-results = df.collect()
-# get first batch
-batch = results[0]
-# convert to Pandas
-df = batch.to_pandas()
# collect as pandas
df = df.to_pandas() |
simicd
force-pushed
the
feature/to-pandas
branch
from
61b5da6 to
8276725
Compare
simicd
force-pushed
the
feature/to-pandas
branch
from
1251f44 to
238050e
Compare
Contributor
Author
|
Thanks for already looking into the PR @andygrove, implemented your feedback and set the PR as ready for final review. |
andygrove
approved these changes
Feb 22, 2023
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @simicd and @krzysztof-kwitt.
|
I wonder if this method will still work for empty result - 0 rows/batches. @simicd What do you think? |
andygrove
added a commit
that referenced
this pull request
Feb 22, 2023
* changelog (#188) * Add Python wrapper for LogicalPlan::Sort (#196) * Add Python wrapper for LogicalPlan::Aggregate (#195) * Add Python wrapper for LogicalPlan::Limit (#193) * Add Python wrapper for LogicalPlan::Filter (#192) * Add Python wrapper for LogicalPlan::Filter * clippy * clippy * Update src/expr/filter.rs Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com> --------- Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com> * Add tests for recently added functionality (#199) * Add experimental support for executing SQL with Polars and Pandas (#190) * Run `maturin develop` instead of `cargo build` in verification script (#200) * Implement `to_pandas()` (#197) * Implement to_pandas() * Update documentation * Write unit test * Add support for cudf as a physical execution engine (#205) * Update README in preparation for 0.8 release (#206) * Analyze table bindings (#204) * method for getting the internal LogicalPlan instance * Add explain plan method * Add bindings for analyze table * Add to_variant * cargo fmt * blake and flake formatting * changelog (#209) --------- Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com> Co-authored-by: Dejan Simic <10134699+simicd@users.noreply.github.com> Co-authored-by: Jeremy Dyer <jdye64@gmail.com>
Contributor
Author
|
@krzysztof-kwitt Good catch! Indeed, it fails with an error - I opened #234 to track the issue |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #139.
Rationale for this change
Convert datafusion dataframe directly to a pandas dataframe
What changes are included in this PR?
Implement
to_pandas()method using pyarrow libraryAre there any user-facing changes?
New
to_pandas()method