Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda.yaml baseline workflow file #281

Merged
merged 39 commits into from
Apr 23, 2023

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Mar 14, 2023

Which issue does this PR close?

Closes #280

@mbrobbel
Copy link

@jdye64 I created oxidecomputer/typify#221. Hopefully this helps with building the substrait crate in environments without rustfmt available.

@jdye64
Copy link
Contributor Author

jdye64 commented Mar 15, 2023

@jdye64 I created oxidecomputer/typify#221. Hopefully this helps with building the substrait crate in environments without rustfmt available.

Thank you for noticing my trail of pain in the commit messages and opening that PR @mbrobbel haha. I appreciate it. I kept getting so close and just something about the virtual conda build environment that gets created just will not find that appropriate installation of rustfmt no matter what I try

@andygrove andygrove mentioned this pull request Mar 31, 2023
@jdye64
Copy link
Contributor Author

jdye64 commented Apr 20, 2023

@andygrove could you approve @charlesbluca so CI can run his commit?

@jdye64 jdye64 marked this pull request as ready for review April 20, 2023 21:10
@andygrove andygrove merged commit b6c600d into apache:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conda build to CI
4 participants