Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Fix minor warning on unused import #289

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 17, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

Got a warning when verifying 20.0.0 RC 2 release:

warning: unused import: `py_runtime_err` 386/387: datafusion-python                                                                                                                                                                  
  --> src/expr/literal.rs:18:21
   |
18 | use crate::errors::{py_runtime_err, DataFusionError};
   |                     ^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default


warning: 1 warning emitted===========> ] 386/387: datafusion-python                                                                                                                                                                  

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@andygrove andygrove merged commit e50e204 into apache:main Mar 18, 2023
@viirya
Copy link
Member Author

viirya commented Mar 18, 2023

Thanks @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants