Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SessionContext execute. #353

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

kylebrooks-8451
Copy link
Contributor

Which issue does this PR close?

Closes #351

Rationale for this change

The execute function in SessionContext didn't work before.

What changes are included in this PR?

Fix the SessionContext execute function to use the existing SessionState.

Are there any user-facing changes?

No.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice to add a unit test for this at some point.

@andygrove andygrove merged commit 6642660 into apache:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionContext execute broken
2 participants