Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(docs): Add user guide (#432) #445

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Aug 4, 2023

Which issue does this PR close?

Closes #432

What changes are included in this PR?

This PR includes additional changes in the documentation to make it coherent with the User Guide and the documentation from the DataFusion main project

Are there any user-facing changes?

Yes, the documentation page will change.

@mesejo
Copy link
Contributor Author

mesejo commented Aug 4, 2023

To make it easier to review, I can try to deploy the documentation at ReadTheDocs.

@jdye64
Copy link
Contributor

jdye64 commented Aug 4, 2023

I am always a fan of doc contribs! I'm going to read through this over the next few days to check for validity and give a formal review. However, doesn't matter still love when people contribute docs! Thanks @mesejo. Just wanted to let you know I will be looking at it.

@alamb
Copy link

alamb commented Aug 7, 2023

@MrPowers would you have time to give this a look as well?

@mesejo mesejo force-pushed the enhacement/new-users-guide branch 3 times, most recently from 08b7856 to d5e8c49 Compare August 7, 2023 16:02
Copy link

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this document and it is really nice @mesejo -- thank you very much

I had a few small comments, but I think they could be done in follow on PRs too.

docs/source/user-guide/introduction.rst Outdated Show resolved Hide resolved
docs/source/user-guide/basics.rst Outdated Show resolved Hide resolved
docs/source/user-guide/basics.rst Show resolved Hide resolved
@mesejo mesejo force-pushed the enhacement/new-users-guide branch from d5e8c49 to 82fb72c Compare August 9, 2023 18:13
@alamb alamb merged commit e34d203 into apache:main Aug 10, 2023
11 checks passed
@alamb
Copy link

alamb commented Aug 10, 2023

Thanks again @mesejo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New users guide
3 participants