Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for window function bindings #521

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Oct 17, 2023

Which issue does this PR close?

Closes #520

@andygrove
Copy link
Member

@jdye64 Is there any overlap between this PR and the recently merged PR that added Window Frame bindings?

#509

@jdye64
Copy link
Contributor Author

jdye64 commented Oct 18, 2023

I had missed that one. Yes, seems to be a lot of overlap. Let me rebase with main and remove the duplicate pieces.

@jdye64
Copy link
Contributor Author

jdye64 commented Oct 18, 2023

I think I'm going to move window_frame.rs into the expr directory since that lines up with arrow-datafusion location and also rename it to just window.rs and include both window and window_frame logic in the single file. Will post the commit here shortly.

src/expr/window.rs Outdated Show resolved Hide resolved
@andygrove
Copy link
Member

@dlovell fyi

@andygrove andygrove merged commit c6a7af5 into apache:main Oct 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bindings for window functions
2 participants