Enable mimalloc local_dynamic_tls feature #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been experiencing issues in dask-sql with dynamic TLS allocation when building on linux and targeting aarch64. More details on the errors and approaches can be found at dask-contrib/dask-sql#1169
However, it seems practical to me to at least propose enabling the mimalloc
local_dynamic_tlsfeature by default in ADP so that downstream libraries do you encounter this sort of behavior. I am open to other suggestions or configuration options as well but just wanted to get something started.