Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_json to SessionContext #56

Merged
merged 8 commits into from
Nov 2, 2022
Merged

Conversation

larskarg
Copy link
Contributor

@larskarg larskarg commented Oct 12, 2022

Related to #28.

MR adds functionality to read json files. I have added some tests cases (not all parameters are covered). Please let me know if the test cases are sufficient and/or if I should store the test data differently.

Example:

import datafusion
ctx = datafusion.SessionContext()
df = ctx.read_json("data.json")
df.show()

src/context.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@francis-du francis-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larskarg

@andygrove
Copy link
Member

@larskarg It looks like there is a Python lint issue and also needs an upmerge

@larskarg
Copy link
Contributor Author

larskarg commented Oct 13, 2022

@andygrove

Upmerge done.

I did also run

flake8 --exclude venv --ignore=E501
black --line-length 79 --diff --check .

locally but didn't see any Python lint issues. Unfortunately, I cannot trigger the github workflow as a first-time contributor. Can you please point me to the Python lint issue? Thanks.

src/context.rs Outdated Show resolved Hide resolved
@jimexist jimexist merged commit 12bb587 into apache:master Nov 2, 2022
@francis-du
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants