Allow PyDataFrame to be used from other projects #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Feb 10, 2024
| @@ -37,7 +37,7 @@ mod config; | |||
| #[allow(clippy::borrow_deref_ref)] | |||
| pub mod context; | |||
| #[allow(clippy::borrow_deref_ref)] | |||
| mod dataframe; | |||
| pub mod dataframe; | |||
There was a problem hiding this comment.
This is the main change
|
@jdye64 fyi |
jdye64
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #581
Rationale for this change
I would like other projects (such as PyBallista) to be able to re-use the
PyDataFramestruct.See apache/datafusion-ballista#976 for an example of how this is leveraged.
What changes are included in this PR?
Make some things public.
Are there any user-facing changes?