Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: While each commit is a self-contained "logical" change, the project needs all the commits to compile.
Which issue does this PR close?
Closes #663. (hopefully)
This is a cleaned up version of #662.
Importantly, the final failing test is not commented out, so there is 1 failing test.
The error and test case are highlighted in this commit from previous PR: ecff357
What changes are included in this PR?
Are there any user-facing changes?
Much of
src/functions.rs
have been updated per the upstream epic: apache/datafusion#9285