Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs deploy action #721

Merged
merged 2 commits into from
May 31, 2024
Merged

Docs deploy action #721

merged 2 commits into from
May 31, 2024

Conversation

Michael-J-Ward
Copy link
Contributor

Rationale for this change

I think the condition for deploying the docs was wrong. When a tag is pushed to main, the github.ref is the tag, not the branch name.

I also added a debug print step because I'm uncertain and would like to verify.

andygrove
andygrove approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Michael-J-Ward

@andygrove andygrove merged commit 84c1195 into apache:main May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-J-Ward @andygrove