-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyExpr to_variant conversions #793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
force-pushed
the
pyexpr-variants
branch
from
July 31, 2024 06:33
ac4ba9c
to
3b194f3
Compare
Michael-J-Ward
changed the title
WIP: Add PyExpr to_variant conversions
Add PyExpr to_variant conversions
Jul 31, 2024
andygrove
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Michael-J-Ward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #781.
Rationale for this change
The user bug report filed
In fixing this bug, I found that upstream datafusion has added explicit structs for many of the variants, so I also updated the datafusion-python variants for those.
Lastly,
datafusion-python
was incorrectly returning thelogical_plan::Sort
instead of theexpr::Sort
as the variant for theExpr::Sort
.Changes
These
Py-Variants
now wrap the upstream variant structs.PyAlias
now wrapsdatafusion_expr::expr::Alias
PyExists
now wrapsdatafusion_expr::expr::Exists
PyInList
now wrapsdatafusion_expr::expr::PyInList
PyInSubquery
now wrapsdatafusion_expr::expr::InSubquery
PyPlaceholder
now wrapsdatafusion_expr::expr::Placeholder
Disambiguating
datafusion_expr::logical_plan::*
anddatafusion_expr::expr::*
variantsPyExpr::to_variant
was incorrectly returning variantsdatafusion_expr::logical_plan::Sort
anddatafusion_expr::logical_plan::Unnest
.PySortExpr
was created to wrap datafusion_expr::expr::SortPyUnnestExpr
was created to wrap datafusion_expr::expr::UnnestNOTE I chose
PySortExpr
because that is howdatafusion_expr
re-exports expr::Sort as SortExprPyExpr::to_variant
additionally implemented forSimilarTo
Between
Case
Cast
TryCast
InList
Exists
InSubquery
ScalarSubquery
GroupingSet
Placeholder