feat: enable list of paths for read_csv #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
timsaucer
reviewed
Aug 20, 2024
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
Overall looks like a nice addition.
| .file_extension(file_extension) | ||
| .table_partition_cols(convert_table_partition_cols(table_partition_cols)?) | ||
| .file_compression_type(parse_file_compression_type(file_compression_type)?); | ||
| options.schema = schema.as_ref().map(|x| &x.0); |
Contributor
Author
There was a problem hiding this comment.
This line sets the options.schema; it is equivalent to the lines (that were deleted),
if let Some(py_schema) = schema {
options.schema = Some(&py_schema.0);I chose to do it this way to remove a nested conditional since the type must be checked to support list and string.
timsaucer
approved these changes
Aug 20, 2024
andygrove
approved these changes
Aug 22, 2024
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Thanks @mesejo and @timsaucer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Enable users to supply a list of csv file paths to the
read_csvfunction, inspired by this issue: ibis-project/ibis#9866.What changes are included in this PR?
Changes to the
read_csvfunction in Rust and the corresponding signature types in PythonAre there any user-facing changes?
Yes