Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Maturin to 0.14.2 #85

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

martin-g
Copy link
Member

0.13.1 hangs on Linux ARM64

Command used to re-generate the hashes:

pip-compile --generate-hashes --upgrade-package maturin requirements.in

Which issue does this PR close?

Closes #84 .

Rationale for this change

There is no problem is latest version of maturin (0.14.2)

What changes are included in this PR?

Updates maturin from 0.13.1 to 0.14.2

Are there any user-facing changes?

Build dependency is updated

0.13.1 hangs on Linux ARM64

Command used to re-generate the hashes:

 `pip-compile --generate-hashes --upgrade-package maturin requirements.in`

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martin-g

@andygrove andygrove merged commit 9ca7c1f into apache:master Nov 28, 2022
@andygrove
Copy link
Member

andygrove commented Nov 28, 2022

@martin-g After merging this, I see it has caused a failure in building the Python wheels.

https://github.com/apache/arrow-datafusion-python/actions/runs/3566140311/jobs/5992260113

Tracking issue: #87

@martin-g
Copy link
Member Author

martin-g commented Nov 28, 2022 via email

@martin-g
Copy link
Member Author

I can't reproduce it here due to:

$ docker pull ghcr.io/pyo3/maturin:v0.14.2
Error response from daemon: Head "https://ghcr.io/v2/pyo3/maturin/manifests/v0.14.2": denied: denied

weird...

@martin-g
Copy link
Member Author

I can pull the image on another machine!
I'm debugging it!

@martin-g
Copy link
Member Author

@andygrove

With v0.13.1 maturin build --help says: Note that manylinux1 is unsupported by the rust compiler.
With v0.14.2 it now says: Note that manylinux1andmanylinux2010 is unsupported by the rust compiler.

Do you really need to support manylinux2010 ?

@andygrove
Copy link
Member

Do you really need to support manylinux2010 ?

I'm very new to Python packaging, so not really qualified to answer this.

Maybe @isidentical has thoughts on this?

@andygrove
Copy link
Member

Do we just need to use a newer version of manylinux?

@martin-g
Copy link
Member Author

I've just re-tested with maturin 0.13.7 (last from 0.13.x) and it hangs on Linux ARM64.
0.14.0 works on Linux ARM64 but does not support manylinux2010.
@andygrove If you need to support manylinux2010 then feel free to revert my commit (or I can send a new PR). Otherwise I can send a new PR to build for manylinux2012 instead.

@isidentical
Copy link
Contributor

Do you really need to support manylinux2010 ?

The only active Python releases that can't handle manylinux2014 is the ones between >=3.7.0,<3.7.9 (so only older bugfix releases of 3.7), and looking at the download stats from PyPI package 3.7 as a whole (which we would be still supporting, but only 3.7.8+ for wheels) represents only a very small percentage of the downloads across all versions. So I think it is safe to move with 2014.

P.S: I also wanted checked polars to see what they are doing, and it seems like they are also publishing wheels for manylinux2014. I'd say let's go for it (and let's also add arm wheels)

@andygrove
Copy link
Member

Thanks @martin-g and @isidentical. Moving to manylinux2014 sounds good to me. I noticed that Ballista is already using this version.

@martin-g
Copy link
Member Author

Good!
I will send a PR shortly!

@martin-g martin-g deleted the update-maturin-to-0.14.2 branch November 29, 2022 06:54
martin-g added a commit to martin-g/arrow-datafusion-python that referenced this pull request Nov 29, 2022
As agreed at apache#85
the version of manylinux is bumped from 2010 to 2014

Reason: Maturin 0.14.+ does not support manylinux 2010 anymore

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g mentioned this pull request Nov 29, 2022
andygrove pushed a commit that referenced this pull request Nov 29, 2022
As agreed at #85
the version of manylinux is bumped from 2010 to 2014

Reason: Maturin 0.14.+ does not support manylinux 2010 anymore

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maturin build hangs on Linux ARM64
4 participants