-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Maturin to 0.14.2 #85
Conversation
0.13.1 hangs on Linux ARM64 Command used to re-generate the hashes: `pip-compile --generate-hashes --upgrade-package maturin requirements.in` Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martin-g
I'll take a look later!
…On Mon, Nov 28, 2022, 18:10 Andy Grove ***@***.***> wrote:
@martin-g <https://github.com/martin-g> After merging this, I see it has
caused a failure in building the Python wheels.
https://github.com/apache/arrow-datafusion-python/actions/runs/3566140311/jobs/5992260113
—
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQULVGXSB4N6SRL7SA3WKTKQTANCNFSM6AAAAAASNK3X6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I can't reproduce it here due to:
weird... |
I can pull the image on another machine! |
With v0.13.1 Do you really need to support manylinux2010 ? |
I'm very new to Python packaging, so not really qualified to answer this. Maybe @isidentical has thoughts on this? |
Do we just need to use a newer version of manylinux? |
I've just re-tested with maturin 0.13.7 (last from 0.13.x) and it hangs on Linux ARM64. |
The only active Python releases that can't handle
|
Thanks @martin-g and @isidentical. Moving to manylinux2014 sounds good to me. I noticed that Ballista is already using this version. |
Good! |
As agreed at apache#85 the version of manylinux is bumped from 2010 to 2014 Reason: Maturin 0.14.+ does not support manylinux 2010 anymore Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
As agreed at #85 the version of manylinux is bumped from 2010 to 2014 Reason: Maturin 0.14.+ does not support manylinux 2010 anymore Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
0.13.1 hangs on Linux ARM64
Command used to re-generate the hashes:
pip-compile --generate-hashes --upgrade-package maturin requirements.in
Which issue does this PR close?
Closes #84 .
Rationale for this change
There is no problem is latest version of
maturin
(0.14.2)What changes are included in this PR?
Updates maturin from 0.13.1 to 0.14.2
Are there any user-facing changes?
Build dependency is updated