release-testing #889
Merged
release-testing #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to run the test suite against a release candidate hosted on test.pypi.org. ``` pip install --extra-index-url https://test.pypi.org/simple/ datafusion==40.0.0 pytest --import-mode=importlib python/tests ```
timsaucer
approved these changes
Oct 4, 2024
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
I've always seen the former approach of #!/bin/bash. For my own edification, why this change?
There was a problem hiding this comment.
My mental model for env is basically "search $PATH for this executable and use it".
The pattern is more commonly used for things like python, i.e. #!/usr/bin/env python because then the script will automatically use whatever virtual environment you have activated.
It's less commonly used for bash, but I use a pretty niche operating system (NixOS) which doesn't use /bin/bash.
❯ which bash
/nix/store/lmv9b9jbhv68kp5pg467rlgg71lf0zyl-bash-interactive-5.2p26/bin/bash
❯ ls -l /usr/bin
total 4
lrwxrwxrwx 1 root root 65 Oct 3 06:58 env -> /nix/store/0kg70swgpg45ipcz3pr2siidq9fn6d77-coreutils-9.5/bin/env
❯ ls -l /bin
total 4
lrwxrwxrwx 1 root root 74 Oct 3 06:58 sh -> /nix/store/qqz0gj9iaidabp7g34r2fb9mds6ahk8i-bash-interactive-5.2p32/bin/sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #804.
Rationale for this change
An error in a prior release wasn't caught because the test instructions
What changes are included in this PR?
clean.shdev script was added for easily cleaning maturin build artifacts.Are there any user-facing changes?
No