Fixes #81 - Add CI workflow for source distribution #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
|
Build result could be seen in my fork - |
andygrove
reviewed
Dec 1, 2022
| ] | ||
| exclude = [".github/**", "ci/**", ".asf.yaml"] | ||
| # Require Cargo.lock is up to date | ||
| locked = true |
There was a problem hiding this comment.
Will this fail the build if Cargo.lock is not up-to-date? This action doesn't run until we tag the release candidate so there is a good chance this will fail unless we also have a CI check on PRs to make sure Cargo.lock is up-to-date?
There was a problem hiding this comment.
Is there a reason why the build workflow is not enabled for Pull Requests ?
It does not publish anything. I think it is safe to enable it! This way we could notice problems earlier!
|
The same config is used for the CI build workflow so it should fail on
master too.
…On Thu, Dec 1, 2022, 18:02 Andy Grove ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pyproject.toml
<#93 (comment)>
:
> @@ -55,4 +55,9 @@ repository = "https://github.com/apache/arrow-datafusion-python"
profile = "black"
[tool.maturin]
-sdist-include = ["Cargo.lock"]
+include = [
+ { path = "Cargo.lock", format = "sdist" }
+]
+exclude = [".github/**", "ci/**", ".asf.yaml"]
+# Require Cargo.lock is up to date
+locked = true
Will this fail the build if Cargo.lock is not up-to-date? This action
doesn't run until we tag the release candidate so there is a good chance
this will fail unless we also have a CI check on PRs to make sure
Cargo.lock is up-to-date?
—
Reply to this email directly, view it on GitHub
<#93 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQVPR4Z4N24XXYXW3EDWLDDZBANCNFSM6AAAAAASQS6QGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
andygrove
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #81 .
Rationale for this change
Release source distribution in addition to the binary wheels.
What changes are included in this PR?
Adapted the config in pyproject.toml and added a new CI job.
Are there any user-facing changes?
No.