-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrain JSON_TABLE table function parsing to MySqlDialect and AnsiDialect #1123
Closed
Closed
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d7727a1
Restrain JSON_TABLE to MySqlDialect
viirya 5f73e1a
Add test for generic dialect
viirya be776e5
Restore rustfmt change
viirya bed4af3
Add test
viirya d7fdae5
Add more dialects to negative test
viirya 6febd52
Fix format
viirya df1398b
Merge remote-tracking branch 'origin/main' into restrain_json_table
alamb 0b225bf
More
viirya e1e5c41
Fix
viirya b7a4d3b
Fix
viirya 80a3dda
Cleanup
viirya 7f7d764
Update src/parser/mod.rs
viirya b27da0f
Update src/ast/mod.rs
viirya 545c661
Remove redundant whitespace
viirya 96ecfb1
For review and fix tests
viirya 8ce05b3
Fix clippy
viirya cd10ba5
Only prevent keyword as identifier under ANSI mode
viirya 7b803a3
Restore test change
viirya ff4c995
Fix test
viirya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the actual change, right? It seems like the changes to derive/src/lib.rs are unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds a little bit adhoc. Shouldn't this be a method on dialect ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON_TABLE seems to be implemented on oracle too, for instance: https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/JSON_TABLE.html#GUID-3C8E63B5-0B94-4E86-A2D3-3D4831B67C62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And on DB2: https://www.ibm.com/docs/en/i/7.3?topic=data-using-json-table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alamb Yea,
derive/src/lib.rs
was changed by rustfmt. I restored it manually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have dialects for Oracle and DB2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be discussed separately, but this syntax follows existing ones.