Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unload statement #1150

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Support Unload statement #1150

merged 5 commits into from
Feb 29, 2024

Conversation

jonathanlehto
Copy link
Contributor

@jonathanlehto jonathanlehto commented Feb 29, 2024

@@ -8351,6 +8351,67 @@ fn parse_binary_operators_without_whitespace() {
);
}

#[test]
fn parse_unload() {
let unload = verified_stmt("UNLOAD(SELECT cola FROM tab) TO 's3://...' WITH (format = 'AVRO')");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating -- I haven't seen UNLOAD before

@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Thank you very much @jonathanlehto for this contribution

@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

I took the liberty of merging the branch up from main to fix a merge conflict, as well as fixing a clippy issue

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8101765167

Details

  • 62 of 62 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.914%

Totals Coverage Status
Change from base Build 8101602088: 0.03%
Covered Lines: 20265
Relevant Lines: 23051

💛 - Coveralls

@alamb alamb merged commit e2ce324 into apache:main Feb 29, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 29, 2024

Thanks again @jonathanlehto

@jonathanlehto
Copy link
Contributor Author

No problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants