-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DECLARE parsing for mssql #1235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @devanbenz -- this PR looks good to me other than the CI failure
It looks like a few simple clippy lints to fix
Also thank you @lovasoa for the review
Pull Request Test Coverage Report for Build 8903948369Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…er-rs into feat/add-mssql-declare
Should be good now clippy is not showing any more linting problems. EDIT: disregard, I only ran |
@alamb okay cool, sorry about that. Should be good to go now ran all the ci checks locally with cargo. |
No worries -- thanks @devanbenz for the contribution! |
DECLARE
keyword [MsSql]