Skip to content

fix: Guard against stack overflow in parse_table_and_joins #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eejbyfeldt
Copy link
Contributor

It possible to hit a stack overflow due to parse_table_and_joins
calling parse_table_factor which then calls parse_table_and_joins.

This fixes the issue by adding a recurssion guard in
parse_table_and_joins.

Found by running the fuzzer.

It possible to hit a stack overflow due to `parse_table_and_joins`
calling `parse_table_factor` which then calls `parse_table_and_joins`.

This fixes the issue by adding a recurssion guard in
`parse_table_and_joins`.

Found by running the fuzzer.
@eejbyfeldt
Copy link
Contributor Author

New test case still overflows in debug builds. Probably needs similar changes as done in #1171

Copy link

github-actions bot commented Nov 6, 2024

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 6, 2024
@github-actions github-actions bot closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant