fix: Guard against stack overflow in parse_table_and_joins #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It possible to hit a stack overflow due to `parse_table_and_joins` calling `parse_table_factor` which then calls `parse_table_and_joins`. This fixes the issue by adding a recurssion guard in `parse_table_and_joins`. Found by running the fuzzer.
|
New test case still overflows in debug builds. Probably needs similar changes as done in #1171 |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It possible to hit a stack overflow due to
parse_table_and_joinscalling
parse_table_factorwhich then callsparse_table_and_joins.This fixes the issue by adding a recurssion guard in
parse_table_and_joins.Found by running the fuzzer.