Add support for ASC and DESC in CREATE TABLE column constraints for SQLite. #1462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://sqlite.org/lang_createtable.html
I didn't directly copy the
AUTOINCREMENT
code right above the diff because I happened to read #1430 the other day. Instead I created a new function in Dialect and enabled it inSQLiteDialect
andGenericDialect
—I hope this is ok.I'm also a little disappointed that I couldn't deduplicate the ASC and DESC handling in src/parser/mod.rs. Maybe if/when
if let
chains are stabilized they could be consolidated cleanly…